Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable loading indicators in A4A #10741

Merged
merged 1 commit into from Aug 1, 2017
Merged

Disable loading indicators in A4A #10741

merged 1 commit into from Aug 1, 2017

Conversation

alanorozco
Copy link
Member

Fixes #9664

@alanorozco alanorozco force-pushed the loadingindicators branch 2 times, most recently from f30ebfb to 779a2af Compare August 1, 2017 17:31
@alanorozco alanorozco removed the request for review from dvoytenko August 1, 2017 17:34
@alanorozco alanorozco changed the title Disable loading indicators in A4A Disable loading indicators in A4A (in progress) Aug 1, 2017
dvoytenko
dvoytenko approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@dvoytenko dvoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, but please add test.

@alanorozco alanorozco changed the title Disable loading indicators in A4A (in progress) Disable loading indicators in A4A Aug 1, 2017
@alanorozco alanorozco merged commit c204ef9 into ampproject:master Aug 1, 2017
@alanorozco alanorozco deleted the loadingindicators branch August 1, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alanorozco @dvoytenko @googlebot @ampprojectbot