Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstitute the check to make sure yarn.lock is updated with package.json #10781

Merged
merged 5 commits into from Aug 3, 2017
Merged

Reinstitute the check to make sure yarn.lock is updated with package.json #10781

merged 5 commits into from Aug 3, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 3, 2017 •
edited

This PR makes sure yarn.lock is updated when package.json is updated. The reverse check is not necessary because it's legitimate to update yarn.lock without touching package.json while bringing the yarn install on Travis up to date.

Fixes #10673
Related to #10671

@rsimha rsimha requested a review from erwinmombay August 3, 2017 20:17
@rsimha rsimha self-assigned this Aug 3, 2017
@rsimha rsimha mentioned this pull request Aug 3, 2017
Closed
@rsimha rsimha mentioned this pull request Aug 3, 2017
Closed
@rsimha
Copy link
Contributor Author

rsimha commented Aug 3, 2017

/to @erwinmombay

@rsimha
Copy link
Contributor Author

rsimha commented Aug 3, 2017

Here is an example of pr-check.js running on a PR that changes package.json, but doesn't update yarn.lock: https://travis-ci.org/ampproject/amphtml/jobs/260771315

This is now ready for review.

@rsimha
Copy link
Contributor Author

rsimha commented Aug 3, 2017

/to @choumx

@rsimha rsimha merged commit 477c121 into ampproject:master Aug 3, 2017
@rsimha rsimha deleted the 2017-08-03-Yarn branch August 3, 2017 21:18
cvializ added a commit that referenced this pull request Aug 3, 2017
@cvializ
Revert "Reinstitute the check to make sure yarn.lock is updated with …
a121926 
…package.json (#10781)"

This reverts commit 477c121.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

@dreamofabear dreamofabear Awaiting requested review from dreamofabear

Assignees

@rsimha rsimha

Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsimha @erwinmombay @googlebot @ampprojectbot