New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move integration tests from test/functional/ to test/integration/ #10800
Move integration tests from test/functional/ to test/integration/ #10800
Conversation
/cc @cramforce |
Step 1 successful: All unit tests now run with just Coming up: Fix presubmit and integration test errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thought there would be more problematic tests.
@choumx, yeah, I was surprised. Let's not celebrate too early though. Step 2 successful: Presubmit errors fixed. Step 3 is interesting: There are now a bunch of failures in the tests that were moved to |
Step 3 successful: https://gist.github.com/rsimha-amp/fe64bb089593002207a0c28e6ff4c949 Will merge this as soon as Travis goes green. |
@rsimha-amp I think there was some miscommunication -- we should still be running these moved integration tests on Chrome at least. After commit 36b70ab, we're now skipping a lot of integration tests that were previously running on Travis (latest Chrome). |
Aha, they were previously being run on latest Chrome due to the unqualified I could remove the I'll send you a PR shortly to rectify this. |
All these tests require the AMP runtime to be built, and need a full
gulp build
before they can run. Therefore, they are integration tests, and should be moved fromtest/functional
totest/integration
, or in the case of extensions, fromtest/
totest/integration
. After this PR is merged, #10792 will make it so that we only rungulp css
prior to running the unit tests on Travis. The following will now work:To be followed by #10792
Partial fix to #10785