Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize validator test infra on Travis #10823

Merged
merged 3 commits into from Aug 9, 2017
Merged

Optimize validator test infra on Travis #10823

merged 3 commits into from Aug 9, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 7, 2017

This PR does the following:

  • Uses wrapper gulp tasks for validator and validator/webui tests in order to enable timing.
  • Silences verbose build.py logs on Travis. (Errors, if any, are still printed. Local run behavior during development remains unchanged.)
  • During PR runs, moves validator tests to the integration_tests shard for load balancing
  • Fixes the addons section of travis.yml to include only those that are required by each shard. (This saves a considerable amount of build time when multiplied across all the PR runs in a given day.)

Fixes #10482
Fixes #10833

@rsimha
Copy link
Contributor Author

rsimha commented Aug 7, 2017

/to @honeybadgerdontcare for review.

@rsimha rsimha requested a review from Gregable August 7, 2017 22:37
@rsimha
Copy link
Contributor Author

rsimha commented Aug 7, 2017

/to @Gregable for review

@rsimha rsimha changed the title Clean up validator test output on Travis Optimize validator test infra on Travis Aug 8, 2017
@rsimha
Copy link
Contributor Author

rsimha commented Aug 8, 2017

/to @choumx for review

@rsimha
Copy link
Contributor Author

rsimha commented Aug 8, 2017

Pinging this again.

@rsimha rsimha requested review from powdercloud and removed request for Gregable and dreamofabear August 8, 2017 20:29
@rsimha rsimha merged commit 7b32652 into ampproject:master Aug 9, 2017
@rsimha rsimha deleted the 2017-08-07-Validator branch August 9, 2017 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants