Skip signature check for fake ad type #10863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you tell me how we ensure that this can only occur when the ad creative is trustworthy? |
|
is |
|
Yeah, I think the previous version of the code had such a check in an equivalent place. |
|
Added extra |
taymonbeal
approved these changes
Aug 10, 2017
| @@ -662,6 +662,11 @@ export class AmpA4A extends AMP.BaseElement { | |||
| }) | |||
| .then(status => { | |||
| this.protectedEmitLifecycleEvent_('adResponseValidateEnd'); | |||
| if (getMode().localDev && | |||
There was a problem hiding this comment.
I think you might want these to be nested instead of joined by &&, to ensure that the block is compiled out of production builds. But I could be wrong; I don't know much about how that compiler pass works. Maybe ask Erwin.
There was a problem hiding this comment.
@taymonbeal I tried compiled with gulp dist. The block is being excluded even not nested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the fake ad type, also our /a4a/ proxy