Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use win.Date.now() to mock clock in test #10999

Merged
merged 1 commit into from Aug 18, 2017
Merged

Use win.Date.now() to mock clock in test #10999

merged 1 commit into from Aug 18, 2017

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Aug 18, 2017

No description provided.

jridgewell
jridgewell reviewed Aug 18, 2017
View reviewed changes
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but mocking should mock Date#now, not Date.

@zhouyx zhouyx merged commit 30752bc into ampproject:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell left review comments

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouyx @jridgewell @lannka @googlebot