Introduce experiment for new Fast Fetch signature verifier #11127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevitzky
approved these changes
Aug 29, 2017
| @@ -1961,8 +2000,22 @@ describe('amp-a4a', () => { | |||
| sandbox.restore(); | |||
| }); | |||
|
|
|||
| it('should emit upgradeDelay lifecycle ping', () => { | |||
| it('should emit upgradeDelay lifecycle ping with legacy verifier', () => { | |||
There was a problem hiding this comment.
Should the description here read "...with new verifier" and the test below it "...with legacy verifier"?
keithwrightbos
approved these changes
Aug 31, 2017
| } else if (/a4a-legacy-verifier/.test(win.location.hash)) { | ||
| forceExperimentBranch(win, VERIFIER_EXP_NAME, LEGACY_VERIFIER_EID); | ||
| } else { | ||
| randomlySelectUnsetExperiments(win, { |
There was a problem hiding this comment.
You don't actually need to put this in the else given randomlySelectUnsetExperiments should do nothing if you've already forced the experiment on.
| return win[propertyName] || | ||
| (win[propertyName] = new LegacySignatureVerifier(win)); | ||
| if (!win[propertyName]) { | ||
| if (/a4a-new-verifier/.test(win.location.hash)) { |
There was a problem hiding this comment.
let expId = (/a4a-new-verifier/.test(win.location.hash) && NEW_VERIFIER_EID) || (/a4a-legacy-verifier/.test(win.location.hash) && LEGACY_VERIFIER_EID);
if (expId) {
forceExperimentBranch(win, VERIFIER_EXP_NAME, expId);
}
randomlySelectUnset...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once a traffic fraction is set, this will cause production traffic to start using the new signature verifier.
Related to #7618. Follow-up to #10674.
CC @ampproject/cloudflare