Polyfill for shadowRoot.styleSheets in Safari #11267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
force-pushed
the
bug/safari-shadow
branch
from
0166cc3
to
8925073
Compare
dvoytenko
reviewed
Sep 11, 2017
src/shadow-embed.js
Outdated
| if (!shadowRoot.styleSheets) { | ||
| Object.defineProperty(shadowRoot, 'styleSheets', { | ||
| get: function() { | ||
| return new StyleSheetListImpl(shadowRoot); |
There was a problem hiding this comment.
Unfortunately, everywhere we use this property is via array access. E.g. x.styleSheets[0]. I'm thinking maybe let's use array instead? Or any other idea?
There was a problem hiding this comment.
Ah I missed that, I was just reading the spec which only offers an items property.
dvoytenko
approved these changes
Sep 11, 2017
erwinmombay
pushed a commit
that referenced
this pull request
Sep 11, 2017
* Polyfill for shadowRoot.styleSheets in Safari * Use array instead of adding an index operator
zhouyx
pushed a commit
that referenced
this pull request
Sep 13, 2017
* Polyfill for shadowRoot.styleSheets in Safari * Use array instead of adding an index operator
zhouyx
pushed a commit
that referenced
this pull request
Sep 13, 2017
* Polyfill for shadowRoot.styleSheets in Safari * Use array instead of adding an index operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11266
It creates a new list each access, but it will always be up to date if any stylesheets are added. Open to suggestions.