Run linter on build-system #11325
Merged
Run linter on build-system #11325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @choumx @erwinmombay |
|
/to @cramforce |
cramforce
approved these changes
Sep 19, 2017
erwinmombay
reviewed
Sep 19, 2017
| @@ -19,9 +19,11 @@ | |||
| var argv = require('minimist')(process.argv.slice(2)); | |||
| var config = require('../config'); | |||
| var eslint = require('gulp-eslint'); | |||
| var getStdout = require('../exec.js').getStdout; | |||
erwinmombay
reviewed
Sep 19, 2017
| * @return {!Stream} Readable stream | ||
| * Initializes the linter stream based on globs | ||
| * @param {!object} globs | ||
| * @param {!object} streamOptions |
erwinmombay
reviewed
Sep 19, 2017
| * Runs the linter on the given stream using the given options. | ||
| * @param {!string} path | ||
| * @param {!ReadableStream} stream | ||
| * @param {!object} options |
|
@erwinmombay Fixes coming in a follow up PR. If only we had a linter to catch these ;) |
|
most of these wouldnt have been caught by the linter as they are bad type annotations. (we don't run the type checker on the build system either, probly not worth it but still good to have the correct annotations) |
This was referenced Sep 21, 2017
|
All your comments are addressed in the follow up PRs listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ES5 compatible linter rules for the
build-systemdirectory, and ensures that any file in that directory that is touched by a PR is also linted. For now, we do this in warning mode, until a first round of fixes is checked in.To run this locally, use:
Coming up: A follow up PR with slightly more sane lint rules, and an initial round of fixes for the
build-systemfiles.Partial fix for #11273.