Fix Safari 11 PKCS bug #11396
Merged
Fix Safari 11 PKCS bug #11396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkeller
approved these changes
Sep 22, 2017
| /** @private @const {?webCrypto.SubtleCrypto} */ | ||
| this.subtle_ = getSubtle(win); | ||
| this.subtle_ = subtle; |
There was a problem hiding this comment.
Nit: Any reason to not just use this.subtle_ on lines 37, 39?
There was a problem hiding this comment.
Then it couldn't be @const anymore.
jridgewell
approved these changes
Sep 22, 2017
|
Good point. Disregard.
…On Sep 22, 2017 7:59 PM, "Taymon A. Beal" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/service/crypto-impl.js
<#11396 (comment)>:
> /** @Private @const {?webCrypto.SubtleCrypto} */
- this.subtle_ = getSubtle(win);
+ this.subtle_ = subtle;
Then it couldn't be @const anymore.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#11396 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACV2BwDtQY-U630wM0UFgNltPQ2BNYEBks5slEn8gaJpZM4PhWiM>
.
|
|
Hey, anything blocking a merge at this point? |
camelburrito
pushed a commit
that referenced
this pull request
Sep 25, 2017
dmvjs
pushed a commit
to dmvjs/amphtml
that referenced
this pull request
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 11 finally started supporting the modern unprefixed Web Crypto API, but left the old one around for backwards compatibility. This played havoc with our feature detection and caused any attempt to use public-key crypto on Safari 11 (i.e., Fast Fetch preferential rendering) to fail. This fix makes sure that the crypto service always knows which version of the API it's using.
Fixes #11394.