add bt (binary type) query param to error reporting query string
#11452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keithwrightbos what did |
rsimha
approved these changes
Sep 26, 2017
| if (isCanary(self)) { | ||
| url += '&ca=1'; | ||
| } | ||
| // Pass binary type. | ||
| url += '&bt=' + getBinaryType(self); |
There was a problem hiding this comment.
Does this need a check to make sure getBinaryType(self) is a non-empty value?
There was a problem hiding this comment.
shouldn't since there is a default value
|
shouldn't since there is a default value
…On Tue, Sep 26, 2017 at 4:18 PM Raghu Simha ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In src/error.js
<#11452 (comment)>:
> if (isCanary(self)) {
url += '&ca=1';
}
+ // Pass binary type.
+ url += '&bt=' + getBinaryType(self);
Does this need a check to make sure getBinaryType(self) is a non-empty
value?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#11452 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANd2kOL2zM6p5I2joUoRavvX1s6XMMXyks5smYY7gaJpZM4Pk_5A>
.
--
You received this message because you are subscribed to the Google Groups
"amphtml-eng-github" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to ***@***.***
To post to this group, send email to ***@***.***
To view this discussion on the web visit
https://groups.google.com/a/google.com/d/msgid/amphtml-eng-github/ampproject/amphtml/pull/11452/review/65390099%40github.com
<https://groups.google.com/a/google.com/d/msgid/amphtml-eng-github/ampproject/amphtml/pull/11452/review/65390099%40github.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"amphtml-eng" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to ***@***.***
To post to this group, send email to ***@***.***
To view this discussion on the web visit
https://groups.google.com/a/google.com/d/msgid/amphtml-eng/ampproject/amphtml/pull/11452/review/65390099%40github.com
<https://groups.google.com/a/google.com/d/msgid/amphtml-eng/ampproject/amphtml/pull/11452/review/65390099%40github.com?utm_medium=email&utm_source=footer>
.
|
jridgewell
approved these changes
Sep 27, 2017
|
@jridgewell yep, canary's binary type is "canary". I can submit a PR |
dmvjs
pushed a commit
to dmvjs/amphtml
that referenced
this pull request
Jan 31, 2018
dmvjs
added a commit
to dmvjs/amphtml
that referenced
this pull request
Feb 6, 2018
…o ke/amp-addthis * 'ke/amp-addthis' of https://github.com/dmvjs/amphtml: (62 commits) type definitions to appease GCC type definitions to appease GCC type definitions to appease GCC type definitions to appease GCC type definitions to appease GCC type definitions to appease GCC type definitions to appease GCC test fixes Add required logic for view/engagement analytics without an iframe Lojson call refactor; saving WIP Code review cleanup Make all images in AMP have the `async` attribute. (ampproject#11366) skip test (ampproject#11459) Fix having multiple Criteo standalone ads on one page (ampproject#11285) add `bt` (binary type) query param to error reporting query string (ampproject#11452) Enables vendor iframe to send response to creative (ampproject#11306) Remove noisy 3p error for user error reporting (ampproject#11382) Ramp Fast Fetch crypto verifier experiment to 10% (ampproject#11447) Updates doubleclick impl to include docs on fluid (ampproject#11437) Revert "Add a visual diff test for amp-pinterest" (ampproject#11442) ...
dmvjs
added a commit
to dmvjs/amphtml
that referenced
this pull request
Feb 6, 2018
…o jr/amp-addthis * 'jr/amp-addthis' of https://github.com/dmvjs/amphtml: (54 commits) Add required logic for view/engagement analytics without an iframe Lojson call refactor; saving WIP Code review cleanup Make all images in AMP have the `async` attribute. (ampproject#11366) skip test (ampproject#11459) Fix having multiple Criteo standalone ads on one page (ampproject#11285) add `bt` (binary type) query param to error reporting query string (ampproject#11452) Enables vendor iframe to send response to creative (ampproject#11306) Remove noisy 3p error for user error reporting (ampproject#11382) Ramp Fast Fetch crypto verifier experiment to 10% (ampproject#11447) Updates doubleclick impl to include docs on fluid (ampproject#11437) Revert "Add a visual diff test for amp-pinterest" (ampproject#11442) Ramp experiment down to 0 (ampproject#11441) Updated changelog with recent validator release (ampproject#11440) Remove pfx parameter from Doubleclick Fast Fetch reuests (ampproject#11439) Allow element to accept custom share attributes (with fallback); remove other ownerDocument refs Add wait code for amp.article.html (ampproject#11429) fix inabox-viewport test (ampproject#11428) Remove camelcase from data attributes Amp Ad Fast Fetch allow amp-image prefetch (ampproject#11391) ...
dmvjs
added a commit
to dmvjs/amphtml
that referenced
this pull request
Feb 6, 2018
…o jr/amp-addthis * 'jr/amp-addthis' of https://github.com/dmvjs/amphtml: (54 commits) Add required logic for view/engagement analytics without an iframe Lojson call refactor; saving WIP Code review cleanup Make all images in AMP have the `async` attribute. (ampproject#11366) skip test (ampproject#11459) Fix having multiple Criteo standalone ads on one page (ampproject#11285) add `bt` (binary type) query param to error reporting query string (ampproject#11452) Enables vendor iframe to send response to creative (ampproject#11306) Remove noisy 3p error for user error reporting (ampproject#11382) Ramp Fast Fetch crypto verifier experiment to 10% (ampproject#11447) Updates doubleclick impl to include docs on fluid (ampproject#11437) Revert "Add a visual diff test for amp-pinterest" (ampproject#11442) Ramp experiment down to 0 (ampproject#11441) Updated changelog with recent validator release (ampproject#11440) Remove pfx parameter from Doubleclick Fast Fetch reuests (ampproject#11439) Allow element to accept custom share attributes (with fallback); remove other ownerDocument refs Add wait code for amp.article.html (ampproject#11429) fix inabox-viewport test (ampproject#11428) Remove camelcase from data attributes Amp Ad Fast Fetch allow amp-image prefetch (ampproject#11391) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us to identify
controlbucket