Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests for Chai4 #11458

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Enable tests for Chai4 #11458

merged 2 commits into from
Sep 29, 2017

Conversation

dvoytenko
Copy link
Contributor

Closes #11400.
Closes #11398.

@rsimha
Copy link
Contributor

rsimha commented Sep 28, 2017 •
edited

@dvoytenko looks like one of the tests failed on Travis.

@rsimha
Copy link
Contributor

rsimha commented Sep 28, 2017

Same failure as reported in #11398

@dvoytenko
Copy link
Contributor Author

@rsimha-amp PTAL

@dvoytenko dvoytenko merged commit e3856e4 into ampproject:master Sep 29, 2017
@dvoytenko dvoytenko deleted the fixes195 branch September 29, 2017 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @rsimha @googlebot