Add new amp-analytics vendor: New Relic

[bayleedev]

This adds New Relic to the amp-analytics provider list.

Fixes #11463

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[zhouyx]

LGTM with one request.

[zhouyx]

nit: [] is good enough.

[bayleedev]

Updated. Thanks!

[bayleedev]

@zhouyx Thanks for the quick review! I'm just waiting on the legal time to give me the thumbs up on signing that doc.

[zhouyx]

@blainesch Did your company sign the CLA? If so please reply your company name to this thread after the doc is signed. Thanks.

[bayleedev]

I signed it!

[zhouyx]

@blainesch You sign the CLA as an individual contributor right? If that's the case googlebot should be able to pick that up fast.
Did you check that the your email address match?

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.

If so my best suggestion would be to rebase, it sometimes fix the CLA.
Thanks.

[bayleedev]

@zhouyx I signed it as an employer. I created this commit to have my work email address, which is part of the google group I signed the doc with.

Edit:
Looks like authored by was the right email but committed by was the wrong email. I rebased, like you suggested.

[bayleedev]

I signed it!

[zhouyx]

@blainesch If your company signed the CLA, that may take longer. Can you provide the name of your company and we can see if it has been processed or not.

[bayleedev]

@zhouyx it's New Relic, Inc

[zhouyx]

@blainesch I am not able to locate New Relic, Inc on the list. Please note that it typically takes a few days to process the corporate CLA. It you think it's taking longer than expected, please reach out to check status. Thanks!

[bayleedev]

I'll check back later next week. Thank you!

[bayleedev]

@zhouyx any update on the cla?

[zhouyx]

Hmmm I am still not able to find the company name. Just sent out an email to check the status, I'll let you know when I hear back from them. Thanks

[zhouyx]

@blainesch Some update: It appears that New Relic corporate CLA is still under review because it has not yet been signed by the New Relic's representative.
If you happen to know the contact person, please reach out to him/her. Thank you!

[bayleedev]

I saw the form being filled out, are you sure? I can ask them to resubmit it...

[bayleedev]

[bayleedev]

Oh, it emailed them and they thought it was spam. They found it and signed it from the email.

[zhouyx]

@blainesch Good News! New Relic Inc now appears in the accepted corporate CLAs list. Please reply to this thread to enable googlebot to verify : )

[bayleedev]

I signed it!

[googlebot]

CLAs look good, thanks!

[zhouyx]

@blainesch Thanks for the Pull Request! Merged

[bayleedev]

@zhouyx thanks for helping me! I have another question if you have time. I tried to use the snippet and I'm getting an error. You can see an example in this repo:

https://github.com/blainesch/amp/blob/short-amp-snippet/analytics-short.html#L27-L37

Here's a screenshot of the error I'm getting:

Any advice on why this isn't working would be appreciated. Thank you!

[zhouyx]

Hey @blainesch. You are testing against our PROD version which doesn't have your vendor config included yet. That's why amp-analytics can't find a request string.

This PR was merged on Thursday, didn't make to this week's canary cut. Unfortunately you can only test it locally right now. After next week's canary cut, your config will be available by opt into our dev channel .

The change is expected to roll out to prod one week after canary (target at around 11/15)

[bayleedev]

Thank you [: