Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send the correct origin for xhr HEADERS #11467

Merged
merged 3 commits into from
Sep 28, 2017
Merged

Send the correct origin for xhr HEADERS #11467

merged 3 commits into from
Sep 28, 2017

Conversation

camelburrito
Copy link
Contributor

No description provided.

dvoytenko
dvoytenko approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@dvoytenko dvoytenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just one nit.

src/url.js Outdated
@@ -49,6 +49,15 @@ const INVALID_PROTOCOLS = [
export const SOURCE_ORIGIN_PARAM = '__amp_source_origin';

/**
* Returns the correct origin for a given windown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. "window" and "."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@camelburrito camelburrito merged commit 6b07393 into ampproject:master Sep 28, 2017
@camelburrito camelburrito deleted the origin_set branch September 28, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camelburrito @dvoytenko @googlebot