Add built-in vendor configuration for ShinyStat analytics #11483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avimehta
reviewed
Oct 2, 2017
| @@ -1594,6 +1594,40 @@ export const ANALYTICS_CONFIG = /** @type {!JsonObject} */ ({ | |||
| }, | |||
| }, | |||
|
|
|||
| 'shinystat': { | |||
There was a problem hiding this comment.
Would you mind moving this up so that the configs are alphabetical? I know the two or three above are not sorted but we'll fix those separately.
There was a problem hiding this comment.
I moved it between "segment" and "snowplow". (rebased)
|
Also, once the changes go live (7-14 days), you can send out a second PR to update the docs in this file: https://github.com/ampproject/docs/blob/master/content/docs/guides/analytics_amp/analytics-vendors.md |
avimehta
reviewed
Oct 4, 2017
| @@ -234,6 +234,16 @@ | |||
| "actionParameter": "&ck1=$actionParameter1&ck2=$actionParameter2&ck3=$actionParameter3&ck4=$actionParameter4&ck5=$actionParameter5", | |||
| "event": "https://$trackDomain/$trackId/wt?p=432,$contentId,1,_screen_width_x_screen_height_,_screen_color_depth_,1,_timestamp_,_document_referrer_,_viewport_width_x_viewport_height_,0&tz=_timezone_&eid=_client_id_&la=_browser_language_&ct=$actionName&ck1=$actionParameter1&ck2=$actionParameter2&ck3=$actionParameter3&ck4=$actionParameter4&ck5=$actionParameter5&pu=_source_url_" | |||
| }, | |||
| "shinystat": { | |||
There was a problem hiding this comment.
apologies for not point it earlier. Same goes here as well (alphabetical).
There was a problem hiding this comment.
No problems. Fixed.
zhouyx
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our second attempt to add vendor configuration for ShinyStat analytics. The first one stalled due to the use of the temporary "iframePing" flag which is not required anymore.
This new pull request is a single patch. At the time of writing it applies cleanly to the upstream repository.
For reference, previous discussions are #2556 and #2557.