Add amp-story-grid-layer tag #11487
Merged
Add amp-story-grid-layer tag #11487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
newmuis
requested review from
dreamofabear
and removed request for
aghassemi
dreamofabear
approved these changes
Sep 29, 2017
| */ | ||
|
|
||
| /** | ||
| * @fileoverview Embeds a story |
alanorozco
moved this from Ready to Merge (approved + comments addressed)
to Merged
in Stories - By Type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a layer for
amp-storythat is based on CSS grid. The layer exposes a few preset templates (fill,vertical,horizontal, andthirds) and also accepts some CSS grid properties as attributes on its children (currently onlygrid-areais accepted, but this could in theory be extended to other properties as well).