Fix Safari's broken transition !important unset #11508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari won't let you unset an inline `transition: none !important` by setting it to `''`. Instead, you have to first set it to a valid non-important value, then set it to `''`.
jridgewell
force-pushed
the
fix-safari-transition-important
branch
from
d97b396
to
e190f78
Compare
jridgewell
requested review from
dreamofabear
and removed request for
dvoytenko
dreamofabear
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari won't let you unset an inline
transition: none !importantbysetting it to
''. Instead, you have to first set it to a validnon-important value, then set it to
''.Fixes #11453.