Updating SafeFrame version. #11519
Merged
Updating SafeFrame version. #11519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwrightbos
approved these changes
Oct 2, 2017
dreamofabear
pushed a commit
that referenced
this pull request
Oct 2, 2017
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Oct 2, 2017
dreamofabear
pushed a commit
that referenced
this pull request
Oct 2, 2017
* Updating SafeFrame version. (#11519) * Explicitly report past Performance Timineline values. (#11521) Chrome's implementation does not yet support reporting on past values. See https://bugs.chromium.org/p/chromium/issues/detail?id=725567 The good news is that it appears as if we have only reported on fast loads so far :)
rsimha
added a commit
that referenced
this pull request
Oct 3, 2017
rsimha
added a commit
that referenced
this pull request
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the default SafeFrame version passed to each Fast Fetch ad request.
Without this update, Fluid ads will not render at all because they will be requesting an old version of SafeFrame which is incompatible with Fluid.