Update amp-ad-exit docs #11550
Merged
Update amp-ad-exit docs #11550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to reflect changes in #11462
jonkeller
approved these changes
Oct 4, 2017
| @@ -273,8 +276,7 @@ Example: | |||
| }, | |||
| "_3pAnalytics": { | |||
| "defaultValue": "no_response", | |||
| "vendorAnalyticsSource": "VendorXYZ", | |||
| "vendorAnalyticsResponseKey": "findings" | |||
| "iframeTransportSignal": "IFRAME_TRANSPORT_SIGNAL(example-3p-vendor,collected-data)" | |||
There was a problem hiding this comment.
LGTM. You might add a note that (at least for now) adding a space after this comma is not allowed. (See #11461 (comment) )
There was a problem hiding this comment.
(Note that the comma thing is no longer true...)
There was a problem hiding this comment.
@calebcordry is working on nested function calls in URL replacement. we might again restrict the space use here.
There was a problem hiding this comment.
I am not 100% yet. There might be a way to preserve spacing after comma only. I am still thinking it through.
|
@clawr shall we merge this? |
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* Update amp-ad-exit docs to reflect changes in ampproject#11462 * Update amp-ad-exit.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to reflect changes in #11462