Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoubleClick: clarify minimum ratio for multisize #11567

Merged
merged 1 commit into from Oct 17, 2017

Conversation

mcmd
Copy link
Contributor

@mcmd mcmd commented Oct 5, 2017

Explicitly mentioned that the minimum ratio applies to each of the dimensions, separately.
(behavior)

Explicitly mentioned that the minimum ratio applies to each of the dimensions, separately.
Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @glevitzky let me know if I can merge

@ampprojectbot ampprojectbot added this to the Pending Triage milestone Oct 9, 2017
@aghassemi aghassemi merged commit 68f975f into ampproject:master Oct 17, 2017
neko-fire pushed a commit to 3qnexx/amphtml that referenced this pull request Nov 17, 2017
Explicitly mentioned that the minimum ratio applies to each of the dimensions, separately.
@mcmd mcmd deleted the patch-1 branch January 17, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants