Add revjet amp-ad #11625
Merged
Add revjet amp-ad #11625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
reviewed
Oct 12, 2017
ads/revjet.js
Outdated
|
|
||
| global._revjetData = Object.assign({}, data); | ||
|
|
||
| loadScript(global, 'https://cdn.revjet.com/~cdn/JS/03/amp.js', undefined, () => { |
There was a problem hiding this comment.
- Can you please mark the
undefinedparam with its param name? - Shorten line to 80 chars.
loadScript(
global,
'https://cdn.revjet.com/~cdn/JS/03/amp.js',
/* opt_cb */ undefined,
() => {
global.context.noContentAvailable();
});
|
Thank you for the review. The fix has been commited. |
alanorozco
approved these changes
Oct 13, 2017
neko-fire
pushed a commit
to 3qnexx/amphtml
that referenced
this pull request
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RevJet integration for AMP.