amp-ima-video: Adding additional video analytics. #11703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove console.log
aghassemi
suggested changes
Oct 16, 2017
package.json
Outdated
| @@ -30,7 +30,8 @@ | |||
| "babel-polyfill": "6.26.0", | |||
| "document-register-element": "1.5.0", | |||
| "promise-pjs": "1.1.3", | |||
| "web-animations-js": "2.3.1" | |||
| "web-animations-js": "2.3.1", | |||
| "yarn": "^1.2.1" | |||
There was a problem hiding this comment.
please revert this file.
|
Done. I could use help with the build though - I'm not sure how to handle my new ima-player-data.js file. imaVideo.js can't depend on it where it is now. |
|
I see. maybe |
|
Easy enough :) Presubmits are running now. |
aghassemi
approved these changes
Oct 18, 2017
neko-fire
pushed a commit
to 3qnexx/amphtml
that referenced
this pull request
Nov 17, 2017
* Adding additional video analytics for amp-ima-video. Remove console.log * Revert package.json. * Fix presubmit errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds currentTime, duration, and playedRanges.
I could use some quick help organizing/compiling this. Specifically imaVideo.js is not allowed to depend on ima-player-data because it's in the extensions/ folder, so I'd like to know how to handle that (move the file, move the code into an existing file, whatever works).
Resolves #11356
/to @aghassemi