video-manager: honour VideoEvents.VISIBILITY event #11787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
approved these changes
Oct 25, 2017
src/service/video-manager-impl.js
Outdated
| @@ -833,6 +838,8 @@ class VideoEntry { | |||
| // Only muted videos are allowed to autoplay | |||
| this.video.mute(); | |||
|
|
|||
| // | |||
|
@rsimha-amp I believe the Percy failure is a flake (also wondering how I can restart the Percy builds, could not find an option on their UI) |
|
@aghassemi Yes, the percy failure in https://percy.io/ampproject/amphtml/builds/385871 looks like flake. Adding @dvoytenko, who wrote that visual test. There's no way to rerun a percy test similar to Travis. However, you can restart the "integration_test" shard of the travis run for that commit, which will go on to run a new percy build against the same commit. |
neko-fire
pushed a commit
to 3qnexx/amphtml
that referenced
this pull request
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8681
Value of
getIntersectionChangeEntryis not always accurate in cases like Carousel. IfVideoEvents.VISIBILITYsays video is visible, honour it regardless of value ofgetIntersectionChangeEntry.Something that might be fixed by
layers, but this is a low-risk small fix for now.