Small bug fixes to chrome extension #11839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaced control characters with spaces in manifest.json. This was preventing Chrome from loading the extension (https://imgur.com/a/9ZZPz) and Sublime saw them as something different (https://imgur.com/a/VF72g) even if I couldn’t figure out what they were * Added the build outputs (amp-validator.build.*) to a .gitignore file
|
Something this small doesn't need tracking issues. Thanks for addressing. |
honeybadgerdontcare
approved these changes
Oct 28, 2017
neko-fire
pushed a commit
to 3qnexx/amphtml
that referenced
this pull request
Nov 17, 2017
* Replaced control characters with spaces in manifest.json. This was preventing Chrome from loading the extension (https://imgur.com/a/9ZZPz) and Sublime saw them as something different (https://imgur.com/a/VF72g) even if I couldn’t figure out what they were * Added the build outputs (amp-validator.build.*) to a .gitignore file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how the project likes to handle small fixes like this -- is a tracking issue necessary? For each one?
Replaced control characters with spaces in manifest.json. This was preventing Chrome from loading the extension (https://imgur.com/a/9ZZPz) and Sublime saw them as something different (https://imgur.com/a/VF72g) even if I couldn’t figure out what they were. I'm surprised nobody else has had this issue.
Added the build outputs (amp-validator.build.*) to a .gitignore file