Fix inputs with the autofocus attribute #11908
Conversation
extensions/amp-form/0.1/amp-form.js
Outdated
| @@ -251,6 +257,13 @@ export class AmpForm { | |||
|
|
|||
| /** @private */ | |||
| installEventHandlers_() { | |||
| this.viewer_.whenFirstVisible().then(() => { | |||
There was a problem hiding this comment.
we probably want autofocus to take effect everytime document becomes visible (think viewer swipes). whenNextVisible does that (and covers first visibility as well)
There was a problem hiding this comment.
Ah you're right; I thought it was just once after the next time it became visible.
There was a problem hiding this comment.
Is the document state reset between viewer swipes? i.e. would the user expect the field to autofocus again if they swipe to the next document and then swipe back?
There was a problem hiding this comment.
oh naming! :) if you can think of a shorter version of ifAlreadyVisibleOrWhenNextVisible , we can rename. it is a fairly new feature and not used in many places yet.
There was a problem hiding this comment.
haha yeah one of the hardest problems
* Fix inputs with the autofocus attribute * Use whenNextVisible instead
* Fix inputs with the autofocus attribute * Use whenNextVisible instead
Fixes #11892
It was a quick hit so I went ahead and made a PR