Fixes page aspect ratio to 6/19 #11909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
reviewed
Nov 2, 2017
| @@ -609,15 +609,19 @@ export class AmpStory extends AMP.BaseElement { | |||
| const platform = Services.platformFor(this.win); | |||
| if (platform.isSafari() || platform.isIos()) { | |||
| this.mutateElement(() => { | |||
| setStyle(this.element, 'display', 'none'); | |||
| setImportantStyles(this.element, { | |||
There was a problem hiding this comment.
I thought we only want to set initial amp-story styles as important.
There was a problem hiding this comment.
ah sorry, my bad. Didn't see that the one in file is also not important
…ageAspectRatio
dreamofabear
approved these changes
Nov 2, 2017
|
request for merge |
11 tasks
neko-fire
pushed a commit
to 3qnexx/amphtml
that referenced
this pull request
Nov 17, 2017
* fixing style merge conflicts * locking page aspect ratio * locking page aspect ratio
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* fixing style merge conflicts * locking page aspect ratio * locking page aspect ratio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes page aspect ratio to 6/19 as listed in #11848
cc: @alanorozco @newmuis @choumx