adding gradients to all sides #11951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
previously requested changes
Nov 8, 2017
| [desktop] .next-container { | ||
| right: 0; | ||
| background: rgba(33,33,33,0)!important; | ||
| background: -moz-linear-gradient(left, rgba(33,33,33,0) 0%, rgba(33,33,33,0.98) 100%)!important; |
| @@ -314,16 +314,23 @@ export class AmpStory extends AMP.BaseElement { | |||
| buildButtons_() { | |||
| const doc = this.element.ownerDocument; | |||
| const nextButton = doc.createElement('button'); | |||
| const nextButtonContainer = doc.createElement('div'); | |||
There was a problem hiding this comment.
nit: this DOM tree is getting too complicated for a series of createElement's. Consider using utilities found in ./simple-template (see system-layer.js for an example).
| [desktop] .next-container { | ||
| right: 0; | ||
| background: rgba(33,33,33,0)!important; | ||
| background: -moz-linear-gradient(left, rgba(33,33,33,0) 0%, rgba(33,33,33,0.98) 100%)!important; |
|
Actually this change looks fine with a background but not white. The gradient clearly appears choppy. Any suggestions?
|
|
I discussed with Hong and and corrected the gradient values.. all fine now ✌️ |
alanorozco
reviewed
Nov 10, 2017
| this.element.insertBefore( | ||
| renderSimpleTemplate(this.win.document, PAGE_SWITCH_BUTTONS), | ||
| this.element.firstChild | ||
| ); |
…orderGradients
newmuis
approved these changes
Nov 13, 2017
| @@ -54,6 +54,13 @@ | |||
| <p>This is the second page of this story.</p> | |||
| </amp-story-grid-layer> | |||
| </amp-story-page> | |||
|
|
|||
| <amp-story-page id="page-3"> | |||
| <amp-story-grid-layer template="vertical"> | |||
There was a problem hiding this comment.
nit: indentation is off from here down
11 tasks
neko-fire
pushed a commit
to 3qnexx/amphtml
that referenced
this pull request
Nov 17, 2017
* adding gradients to all sides * fixing choppy gradient * removing vendor prefixes * render buttons from simpleTemplate * correct gradient values * fixing indents
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2017
* adding gradients to all sides * fixing choppy gradient * removing vendor prefixes * render buttons from simpleTemplate * correct gradient values * fixing indents
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* adding gradients to all sides * fixing choppy gradient * removing vendor prefixes * render buttons from simpleTemplate * correct gradient values * fixing indents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gradient to all sides of page as mentioned in #11848 last point
cc: @alanorozco @newmuis @choumx