Intent To Implement: Giraff support for amp-ads #12099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
suggested changes
Nov 18, 2017
ads/giraff.md
Outdated
|
|
||
| ## Configuration | ||
|
|
||
| For more information, please see ad network documentation. |
There was a problem hiding this comment.
nit: please add link to your ad network documentation
extensions/amp-ad/amp-ad.md
Outdated
| @@ -236,6 +236,7 @@ See [amp-ad rules](https://github.com/ampproject/amphtml/blob/master/extensions/ | |||
| - [Doubleclick](../../ads/google/doubleclick.md) | |||
| - [E-Planning](../../ads/eplanning.md) | |||
| - [Ezoic](../../ads/ezoic.md) | |||
| - [Giraff](../../ads/giraff.md) | |||
ads/giraff.md
Outdated
| type="giraff" | ||
| data-block-name="novotekaru"> | ||
| </amp-ad> | ||
|
|
* 'master' of github.com:ampproject/amphtml: (47 commits) Fix cloned node dupe id causing activation to fail on non images (#12241) pass window ref to getMode (#12239) Create iframe within amp-ads for inabox (#12211) Analytics: Timer spec provides configuration for starting and stopping (#11813) Validator rollup (#12242) amp-accordion: Add `expand`, `collapse`, `toggle` actions (#11933) amp-video: analytics update desc file (#12230) fix amp-sidebar toolbar issue with chrome when the page takes too long time to be ready (#12204) Web share API is out of origin trial. Fix heroku deployment scripts (#12236) Analytics enable reset visible event (#12094) Doubleclick render idle throttle (#12220) Update async image decoding attribute to updated standard. (#12145) dynamically insert script for unknown extensions found in live-list (#9302) Basic styling of bookend for desktop (#12155) Implement MediaPool for amp-story (#12156) IframeTransport + LongTask API (#11907) amp-layout: enable visual tests (#12158) Update version of eslint (#12179) Stop requiring source origin header for bookend (#11895) ...
|
Looks great! LGTM |
zhouyx
approved these changes
Nov 30, 2017
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2017
* Giraff support for amp-ads * Giraff support for amp-ads. Fixed issues
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* Giraff support for amp-ads * Giraff support for amp-ads. Fixed issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Giraff widgets to amp-ad elements