Calculate share button padding dynamically for scroll affordance #12127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
approved these changes
Dec 6, 2017
extensions/amp-story/0.1/share.js
Outdated
| this.root_./*OK*/offsetLeft; | ||
|
|
||
| const iconWidth = | ||
| dev().assert(items[0].firstElementChild)./*OK*/offsetWidth; |
There was a problem hiding this comment.
Nit: Extract items[0].firstElementChild into a local var.
extensions/amp-story/0.1/share.js
Outdated
| const iconWidth = | ||
| dev().assert(items[0].firstElementChild)./*OK*/offsetWidth; | ||
|
|
||
| // Total width that the buttons will occupy with minimum padding |
jpettitt
pushed a commit
to jpettitt/amphtml
that referenced
this pull request
Dec 11, 2017
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11898.
When the share buttons won't fit in the container, thus making it scrollable, we need a visual affordance so that the user realizes that the element is scrollable.
This change allows the widget to calculate the padding so that there's always an element cut-off if needed, otherwise allows the buttons to have "fluid" padding so that they fit the container.
(This could be done with CSS/flexbox IFF the element wasn't scrollable.)