Write local testing config values to AMP runtime #12152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @erwinmombay @bradfrizzell for review. |
bradfrizzell
approved these changes
Nov 21, 2017
erwinmombay
reviewed
Nov 21, 2017
| * @param {string} opt_local | ||
| * @param {string=} opt_branch | ||
| * @param {string} filename File containing the config | ||
| * @param {string} opt_localBranch Whether to use the local branch version |
There was a problem hiding this comment.
if this is actually opt then add =
erwinmombay
reviewed
Nov 21, 2017
| * @param {string} config Prod or canary | ||
| * @param {string} target File containing the AMP runtime (amp.js or v0.js) | ||
| * @param {string} filename File containing the (prod or canary) config | ||
| * @param {boolean} opt_localDev Whether to enable local development |
There was a problem hiding this comment.
missing = on these optional params
|
@erwinmombay Will merge this shortly, unless you have more comments. |
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2017
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
localDev: true,thirdPartyFrameHost, andthirdPartyFrameRegexare written to the local AMP config to enable local testing withgulp buildandgulp dist --fortesting.--local_devtogulp prepend-global, which will ensure that the AMP runtime is set up for local development and testing.With this,
localDevwill be set to true when the runtime is built and served onlocalhostviagulp, or via the following commands:In addition,
localDevwill be set to true andthirdPartyFrameHostandthirdPartyFrameRegexwill point toAMP_TESTING_HOSTwhen the runtime is built and served from a non-localhost server, via the following commands.Partial fix for #12054