tools(lint): add lint rule for unused vars and params. #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
unused-vars
branch
from
cad69fc
to
5b1c49f
Compare
| @@ -65,7 +62,7 @@ export function twitter(global, data) { | |||
| // Unfortunately the tweet isn't really done at this time. | |||
| // We listen for resize to learn when things are | |||
| // really done. | |||
| iframe.contentWindow.addEventListener('resize', function(e) { | |||
| iframe.contentWindow.addEventListener('resize', function(_e) { | |||
erwinmombay
force-pushed
the
unused-vars
branch
from
5b1c49f
to
575eca3
Compare
erwinmombay
force-pushed
the
unused-vars
branch
from
575eca3
to
eaa05ea
Compare
- any variable that has a suffix `Def` or `Interface` is ignored. - any parameter that has a prefix `_`, `opt_`, `var_`, `unused_` is ignored.
erwinmombay
force-pushed
the
unused-vars
branch
from
eaa05ea
to
fba2484
Compare
|
@cramforce all lint issues resolved |
|
LGTM |
erwinmombay
added a commit
that referenced
this pull request
Dec 23, 2015
tools(lint): add lint rule for unused vars and params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeforInterfaceis ignored.unused_is ignored.Closes #1212
/cc @cramforce @jridgewell @dvoytenko @sriramkrish85
feel free to make any suggestions on any of these conventions.