intersectionRatio & intersectionRect substitution support #12217
Conversation
| const intersectionRect = this.getElementIntersectionRect(opt_element); | ||
| Object.assign(state, { | ||
| 'intersectionRatio': intersectionRatio, | ||
| 'intersectionRect': JSON.stringify(intersectionRect), |
There was a problem hiding this comment.
I can minimize the intersectionRect string by removing intersectionRect.left intersectionRect.top, and also by arrange numbers in order. I figure longer request string is not a big deal and we can add filter function to support this purpose. So I decide to leave as it is. Let me know if anyone has objection.
There was a problem hiding this comment.
I'm wondering if intersectionRect is necessary. isn't ratio enough?
There was a problem hiding this comment.
I feel that intersectionRect is necessary. Customer has said many times that they don't just care about "1/3 of the ad is visible" but they also want to know if it's the top 1/3, or the bottom 1/3, etc.
|
@zhouyx let me know if you want me to help resolve conflicts and merge |
zhouyx
force-pushed
the
intersectrect-sub
branch
from
5349a7d
to
751f381
Compare
|
@lannka resolved and merged. Thanks. |
For #12074