Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new method, failAfterWarningOrError. #12257

Merged
merged 2 commits into from Dec 5, 2017
Merged

Add a new method, failAfterWarningOrError. #12257

merged 2 commits into from Dec 5, 2017

Conversation

powdercloud
Copy link
Contributor

If used instead of failAfterError, gulp will effectively consider validator
warnings as errors. I've extracted a helper routine to avoid
duplicating too much code.

@powdercloud
Add a new method, failAfterWarningOrError. If used instead
338aefd 
of failAfterError, gulp will effectively consider validator
warnings as errors. I've extracted a helper routine to avoid
duplicating too much code.
@powdercloud powdercloud mentioned this pull request Nov 30, 2017
Closed
sebastianbenz
sebastianbenz requested changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM. One thing - could you also update the sample in the readme.

We also should update the dependency to the amp-validator in the package.json. Do you want to do this in this PR, or should we create a separate one?

@powdercloud
Copy link
Contributor Author

@sebastianbenz Done, please take another look. Thank you.

sebastianbenz
sebastianbenz approved these changes Dec 1, 2017
View reviewed changes
Copy link
Contributor

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks a lot!

@ampprojectbot ampprojectbot added this to the Pending Triage milestone Dec 4, 2017
@powdercloud powdercloud merged commit ae3d243 into ampproject:master Dec 5, 2017
@powdercloud powdercloud deleted the fail-after-warning-or-error branch December 5, 2017 00:33
ghost pushed a commit that referenced this pull request Dec 6, 2017
@powdercloud
Add a new method, failAfterWarningOrError. (#12257)
9e991fb 
* Add a new method, failAfterWarningOrError. If used instead
of failAfterError, gulp will effectively consider validator
warnings as errors. I've extracted a helper routine to avoid
duplicating too much code.

* New usage in README and new amphtml-validator version in package.json.
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018
@powdercloud @gzgogo
Add a new method, failAfterWarningOrError. (ampproject#12257)
350ab9f 
* Add a new method, failAfterWarningOrError. If used instead
of failAfterError, gulp will effectively consider validator
warnings as errors. I've extracted a helper routine to avoid
duplicating too much code.

* New usage in README and new amphtml-validator version in package.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
Pending Triage
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@powdercloud @sebastianbenz @honeybadgerdontcare @googlebot @ampprojectbot