Removing CSP related dead code. #12287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkeller
approved these changes
Dec 4, 2017
keithwrightbos
requested changes
Dec 5, 2017
| + 'content'); | ||
| expect(html).to.equal('<html><base href="https://acme.org/embed1">' | ||
| + '<meta http-equiv=Content-Security-Policy content="script-src ' | ||
| + '\'none\';object-src \'none\';child-src \'none\'">content'); | ||
| }); | ||
|
|
||
| it('should insert CSP', () => { | ||
| spec.html = '<html><head></head><body></body></html>'; |
There was a problem hiding this comment.
Can we verify that the violation listener was added?
keithwrightbos
approved these changes
Dec 5, 2017
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2017
* Removing CSP related dead code. * Unused import. * Added test for violation listener inclusion.
jpettitt
pushed a commit
to jpettitt/amphtml
that referenced
this pull request
Dec 6, 2017
* Removing CSP related dead code. * Unused import. * Added test for violation listener inclusion.
jpettitt
added a commit
to jpettitt/amphtml
that referenced
this pull request
Dec 7, 2017
* Removing CSP related dead code. * Unused import. * Added test for violation listener inclusion.
jpettitt
pushed a commit
to jpettitt/amphtml
that referenced
this pull request
Dec 11, 2017
* Removing CSP related dead code. * Unused import. * Added test for violation listener inclusion.
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* Removing CSP related dead code. * Unused import. * Added test for violation listener inclusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.