Protect from null pointer exeption and silent failure #12308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
Dec 5, 2017
| @@ -80,6 +80,11 @@ export class VisibilityModel { | |||
| `Cannot repeat with interval less than ${MIN_REPEAT_INTERVAL}, ` + | |||
| ' repeat set to false'); | |||
| } | |||
| } else { | |||
jonkeller
commented
Dec 5, 2017
| @@ -80,6 +80,11 @@ export class VisibilityModel { | |||
| `Cannot repeat with interval less than ${MIN_REPEAT_INTERVAL}, ` + | |||
| ' repeat set to false'); | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
FYI going to kill the whole if/else on line 65 next, and make repeat only be allowed to be a boolean, not a number. But probably won't get to that before the canary that's in 2 hours.
There was a problem hiding this comment.
you might want to keep this PR simple for easy cherry-pick
taymonbeal
approved these changes
Dec 5, 2017
jonkeller
commented
Dec 5, 2017
| @@ -80,7 +80,6 @@ export class VisibilityModel { | |||
| `Cannot repeat with interval less than ${MIN_REPEAT_INTERVAL}, ` + | |||
| ' repeat set to false'); | |||
| } | |||
| } | |||
lannka
approved these changes
Dec 5, 2017
cvializ
pushed a commit
to cvializ/amphtml
that referenced
this pull request
Dec 5, 2017
* Protect from null pointer exeption and silent failure * Revert log msg addition * Replace accidentally removed brace
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2017
* Protect from null pointer exeption and silent failure * Revert log msg addition * Replace accidentally removed brace
jpettitt
pushed a commit
to jpettitt/amphtml
that referenced
this pull request
Dec 11, 2017
* Protect from null pointer exeption and silent failure * Revert log msg addition * Replace accidentally removed brace
|
@calebcordry Agreed. Just added to #12547.
https://github.com/ampproject/amphtml/pull/12547/files#diff-61c963752cc0a61e2ec5e1561dc0466cR217
…On Fri, Dec 22, 2017 at 12:40 PM, Caleb Cordry ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In extensions/amp-analytics/0.1/visibility-model.js
<#12308 (comment)>:
> @@ -239,8 +239,12 @@ export class VisibilityModel {
});
this.unsubscribe_.length = 0;
this.eventResolver_ = null;
- this.onTriggerObservable_.removeAll();
- this.onTriggerObservable_ = null;
+ // TODO(jonkeller): Investigate why dispose() can be called twice,
+ // necessitating this "if"
+ if (this.onTriggerObservable_) {
+ this.onTriggerObservable_.removeAll();
Should we also add warning here like in #12547
<#12547> ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#12308 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACV2B6UD_IieX9oZldSwOGaJOdfwngFqks5tC-mcgaJpZM4Q2z1g>
.
|
|
I deleted the comment because I saw that you were one step ahead of me as soon as it was sent :) |
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* Protect from null pointer exeption and silent failure * Revert log msg addition * Replace accidentally removed brace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12304