Longtask unit test refactor #12437
Merged
Longtask unit test refactor #12437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkeller
commented
Dec 12, 2017
| @@ -135,52 +136,6 @@ describes.realWin('amp-analytics.iframe-transport', {amp: true}, env => { | |||
| expect(createPerformanceObserverSpy).to.be.called; | |||
| }); | |||
|
|
|||
|
|
|||
| it('logs poor performance of vendor iframe', () => { | |||
There was a problem hiding this comment.
Not deleted, just reordered and then changed a quite a bit.
The main change is the value of frameUrl2, and that we're no longer setting srcdoc. That (and some other deleted stuff) was hoop-jumping necessitated by doNotLoadExternalResourcesInTest() in testing/iframe.js, which is no longer needed because of the new allowExternalResources: true on line 155.
glevitzky
approved these changes
Dec 13, 2017
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* Longtask unit test now uses cross-origin * Longtask unit test now uses cross-origin * Fix mistakes made by gulp lint --fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the unit test test with a cross-origin iframe, instead of a same-origin one, to be more realistic.