Skip PRs from the triage process #12470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Dec 14, 2017
| @@ -67,7 +67,7 @@ const BIWEEKLY_DAYS = 14; | |||
| // days for quarterly updates | |||
| const QUARTERLY_DAYS = 89; | |||
| // we need around 10 batches to get 1k issues | |||
| // if an issue is an pull request will skip it | ||
| if (pullRequest) { | ||
| if (isDryrun) { | ||
| util.log(util.colors.red(issue.number + ' is pull request')); |
There was a problem hiding this comment.
done. Thank you!
| @@ -136,6 +136,13 @@ function updateGitHubIssues() { | |||
| const issueLastUpdate = issue.updated_at; | |||
| let biweeklyUpdate = true; | |||
| let quartelyUpdate = true; | |||
| // if an issue is an pull request will skip it | |||
There was a problem hiding this comment.
if an issue is a pull request, we'll skip it
dreamofabear
approved these changes
Dec 14, 2017
|
Thanks for fixing this! |
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* fixes for automation * fixes for automation * fixes for automation with review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12434
Added more batches also since the number of issues grew.