Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-sidebar - remove experimental v 1.0, all features already merged with 0.1 #12516

Merged
merged 4 commits into from Dec 22, 2017

Conversation

aghassemi
Copy link
Contributor

@aghassemi aghassemi commented Dec 19, 2017

Closes #9803

Copy link
Contributor

@camelburrito camelburrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Uses the same experiment too , please remove the experiment there

@@ -1,255 +0,0 @@
<!---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR also delete the entire sidebar component...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, it's 1.0.

@aghassemi aghassemi merged commit 3097468 into ampproject:master Dec 22, 2017
@torch2424
Copy link
Contributor

Thanks @aghassemi ! 👍

gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants