Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and unskip amp-sidebar tests #12523

Merged
merged 2 commits into from Dec 19, 2017
Merged

Fix and unskip amp-sidebar tests #12523

merged 2 commits into from Dec 19, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Dec 19, 2017

Follow up to #12486
Unblocks #12502
Fixes #12522

@rsimha rsimha requested a review from cathyxz December 19, 2017 16:23
@rsimha
Copy link
Contributor Author

rsimha commented Dec 19, 2017

/to @aghassemi @cathyxz

Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rsimha rsimha changed the title Unskip amp-sidebar tests Fix and unskip amp-sidebar tests Dec 19, 2017
@rsimha rsimha merged commit 37e1655 into ampproject:master Dec 19, 2017
@rsimha rsimha deleted the 2017-12-19-FixLolex branch December 19, 2017 16:46
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants