Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor. Push encountered tag on the stack later after validation. #12564

Merged
merged 1 commit into from Dec 20, 2017

Conversation

Gregable
Copy link
Member

Refactor. Up until now, we would, in order:

  1. Put the encountered tag on the stack
  2. Validate the reference point
  3. Update the context with the refence point spec
  4. Validate the tag spec
  5. Update the context with the tag spec

This refactoring changes that, so now we:

  1. Validate the reference point
  2. Validate the tag spec
  3. Put the encountered tag on the stack (updating parents as needed).
  4. Update the context with the refence point spec
  5. Update the context with the tag spec

This cleans up many methods in the tag stack, places where code would have state about if the back
of the stack was the node being processed, or the parent node, etc.

@Gregable Gregable merged commit ccd15a1 into master Dec 20, 2017
@Gregable Gregable deleted the validator-rollup branch December 20, 2017 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants