Polish and optimize desktop background #12629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
force-pushed
the
background
branch
2 times, most recently
from
21b9677
to
16cd79e
Compare
prateekbh
reviewed
Jan 2, 2018
| background-size: cover !important; | ||
| background-color: transparent !important; | ||
| background-position: center center !important; | ||
| will-change: opacity, z-index !important; |
There was a problem hiding this comment.
are we trying to animate opacity?
last time we did this, opacity animation + page movement tend to get a little janky. please check
There was a problem hiding this comment.
Confirmed as working, issues were caused by lack of transition sync/two transitions at the same time.
| right: 0 !important; | ||
| bottom: 0 !important; | ||
| left: 0 !important; | ||
| top: -150px !important; |
prateekbh
approved these changes
Jan 2, 2018
prateekbh
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores images hidden by media query when finding background source. In some cases, hidden images would be loaded by the background, causing a delay between correct image load and background image load.
Fixes blur bleed.
Sets background color to be the same as the
amp-story-pageelement in case no image is present or when it fails to load.Waits for image to load before swap. On timeout, it will show the background color.
Previous changes allow for crossfade transition to be re-enabled, with some changes in behavior.