Initial set up for greenkeeper-lockfile #12683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
commented
Jan 6, 2018
.travis.yml
Outdated
| @@ -35,7 +38,8 @@ addons: | |||
| sauce_connect: | |||
| username: "amphtml" | |||
| jwt: | |||
| secure: "Wze0F0vGL0UcxryOx1n/vcuD5LIMGyR+69Nc6IWLoRvZBbbIpFwVFhDE6rE9ranIXiA2Hc684N4sV8ASfNDF8RRSB+jyLov159qwgji2rBxIfQ/4kuDV2vYoAJvYMz8m42kwx5FV2VV9awqMMt8mwU3wYIrKIaVCxB34uV86KIlDlbrHxt17Bm5EIiUmwi9r1AAnW/63vVRUN264D77oB4j9UQ759PfD6BDwEt54O87KurNIaLseNCr1IvzfL8veEsZ3uTbLC1GtgHfR4IGgkS2YyN2QIk06VZWeRDEOalS3RcY0nDkbCmBywxIGObnrpEMzOpjBiOb2fxLoLvvpjlla5W84zJGfWE6q4T9IvkyHuDJE+sft5B+arjMIeA6PIeUhKdV27+6qqDEf7fILZ/U/Ekn9ds4zSV8hekAZPUyyPncOeyWppCIJ8sOeCrsebkRjH1BoX/d+FE+nP0bN/XkBpIi/nManx5FyS/kqjQWGKmvsFQfEWlSUaZi7XtEQEjvBizRkzvpJanSDaoiTDS2Keulmwii3XRId51FuGtnfDZFeggLaMTKGfBX9DlPkccwYAZe6vPNfYk1pNgEj6AtnifEhYVEO+aAuWhEnJ86od+1wDOL/h+a2XY6h8/gFBywsD95p7sXPfdVDCKgwagiBo+Hw5MNjztVF7lszg1A=" | |||
| - secure: "Wze0F0vGL0UcxryOx1n/vcuD5LIMGyR+69Nc6IWLoRvZBbbIpFwVFhDE6rE9ranIXiA2Hc684N4sV8ASfNDF8RRSB+jyLov159qwgji2rBxIfQ/4kuDV2vYoAJvYMz8m42kwx5FV2VV9awqMMt8mwU3wYIrKIaVCxB34uV86KIlDlbrHxt17Bm5EIiUmwi9r1AAnW/63vVRUN264D77oB4j9UQ759PfD6BDwEt54O87KurNIaLseNCr1IvzfL8veEsZ3uTbLC1GtgHfR4IGgkS2YyN2QIk06VZWeRDEOalS3RcY0nDkbCmBywxIGObnrpEMzOpjBiOb2fxLoLvvpjlla5W84zJGfWE6q4T9IvkyHuDJE+sft5B+arjMIeA6PIeUhKdV27+6qqDEf7fILZ/U/Ekn9ds4zSV8hekAZPUyyPncOeyWppCIJ8sOeCrsebkRjH1BoX/d+FE+nP0bN/XkBpIi/nManx5FyS/kqjQWGKmvsFQfEWlSUaZi7XtEQEjvBizRkzvpJanSDaoiTDS2Keulmwii3XRId51FuGtnfDZFeggLaMTKGfBX9DlPkccwYAZe6vPNfYk1pNgEj6AtnifEhYVEO+aAuWhEnJ86od+1wDOL/h+a2XY6h8/gFBywsD95p7sXPfdVDCKgwagiBo+Hw5MNjztVF7lszg1A=" | |||
| - secure: "WJxhl/duuCxQW0C5pgpWgrFOvpGabCKhi5IKnyUtaLiWtMXBx4XMYh0ou60zfk5h76cgmXbHcKpHoo6Gyd0enxnwLcnrgP5RdyXPq4lOK8+k/cNNQpXx7VqQl37UohBWeZrEkIFBNOjohlK4jvrOgE4QmZuKwm14dw++CNEI4yNVliLgE6bGyFeaLrVyJufGwDkWKm5aZcq79i+g6BfxYZ5X+otL0XFxaLcWCUUm004taPMYSd1BpZVNuoTnyRsmhSz+wbBdILj7SQMqAj3XIAHAHE4SG9rT7u7Kt236DlAyiIppIL30uttGlS/AHPFpORE6b+kVgO4Xzf4REoGqbK23+TVsdEQJ63NXQcjmFgu9tgNy4+mZ5NDd1rP5zoZTBlo/Co989RgM+gYHJOilc1HYkGOy30O7Im/7FjWPdFmGVmzSYpFPG8zNWM+mNk1Cn74ueyF3GuDw+G5DtVEzwlP8n4qUnVh2TGNkZ8gYlFeUDL0CovvsYPivdK9p2ZQqoLPNKlPC1AqKlo0dyF702NTn36X99q3fMJ/EmspPbaj34Peno1oIAfF4s8zne3l7PiSkAFCFCBUCmyqvwHlvLHJLNtGMf+RG5tlRNZbS7iyW6cQHfftnJrqXuo7cajLU9/5e7qJnyTbu+AUdL+oCYScVU8GQBUHRuPxMHgBZfvs=" | |||
There was a problem hiding this comment.
@cramforce This line is a placeholder, and is the result of travis encrypt GH_TOKEN=foobar. I'll need to replace it with the encrypted version of the real GH_TOKEN, generated as described here: https://github.com/greenkeeperio/greenkeeper-lockfile#setup
There was a problem hiding this comment.
Yes, you need to do the following:
- Go to https://github.com/settings/tokens and create a GitHub access token with push access to
ampproject/amphtml - Run
travis encrypt GH_TOKEN=<token>with the token generated in step 1, and send it to me. - (Optional) If you aren't set up to run
travisin step 2, privately share the token from step 1 with me, and I'll run step 2.
There was a problem hiding this comment.
@cramforce Let me know once you have created the token described above.
There was a problem hiding this comment.
As discussed with @erwinmombay I've generated a GH_TOKEN with just public_repo access. Will test and see if that's sufficient.
cramforce
approved these changes
Jan 6, 2018
This was referenced Jan 9, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the steps outlined at https://github.com/greenkeeperio/greenkeeper-lockfile#setup
This PR is a no-op until #12679 is merged. However, since we have tests to ensure that
yarn.lockis always updated along withpackage.json, this PR must be merged before #12679.Partial fix for #12181