Eliminate the use of Object.values() #12686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @cramforce This is necessary to unblock #12679 |
cramforce
approved these changes
Jan 7, 2018
erwinmombay
reviewed
Jan 8, 2018
| @@ -479,8 +479,12 @@ describe('Google A4A utils', () => { | |||
| }); | |||
| const ampAdElem = env.win.document.createElement('amp-ad'); | |||
| prevContainer.appendChild(ampAdElem); | |||
| const ValidAdContainerTypeValues = | |||
| Object.keys(ValidAdContainerTypes).map(function(key) { | |||
There was a problem hiding this comment.
nvm, guess it was already PascalCase prior to changes
There was a problem hiding this comment.
Yeah, didn't want to edit the rest of the file for this fix.
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error seen in the Travis jobs from #12679
See https://travis-ci.org/ampproject/amphtml/jobs/325672590#L730