Don't rewrite values of binding attributes in sanitizer.js #12688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
approved these changes
Jan 8, 2018
dreamofabear
force-pushed
the
href-binding-sanitizer
branch
from
d14d463
to
455740f
Compare
jridgewell
approved these changes
Jan 8, 2018
dreamofabear
pushed a commit
that referenced
this pull request
Jan 8, 2018
* fix incorrect rewriting of [href] attr vals in sanitizer * lint
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
…t#12688) * fix incorrect rewriting of [href] attr vals in sanitizer * lint
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
…t#12688) * fix incorrect rewriting of [href] attr vals in sanitizer * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12610.
[href]are expressions, not scalars, and should not be modified./to @jridgewell @danielrozenberg