New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for byside analytics #12693
add support for byside analytics #12693
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
@@ -264,6 +264,55 @@ export const ANALYTICS_CONFIG = /** @type {!JsonObject} */ ({ | |||
}, | |||
}, | |||
|
|||
'byside': { | |||
'vars': { | |||
'agentDomain': 'webcare', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
* add support for byside analytics * update byside analytics integration tests * update analytics vendor example for byside
* add support for byside analytics * update byside analytics integration tests * update analytics vendor example for byside
This implements BySide analytics and adds BySide to the amp-analytics provider list.
Fixes #12692 .