Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for byside analytics #12693

Merged
merged 3 commits into from Jan 24, 2018

Conversation

bysidedevel3rdparty
Copy link
Contributor

This implements BySide analytics and adds BySide to the amp-analytics provider list.

Fixes #12692 .

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@bysidedevel3rdparty
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 8, 2018
@jridgewell jridgewell requested a review from lannka January 8, 2018 19:25
@lannka lannka added this to Ads backlog in 3P Ads & Analytics Support Jan 9, 2018
@lannka lannka moved this from Ads backlog to TODO in 3P Ads & Analytics Support Jan 9, 2018
@@ -264,6 +264,55 @@ export const ANALYTICS_CONFIG = /** @type {!JsonObject} */ ({
},
},

'byside': {
'vars': {
'agentDomain': 'webcare',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@lannka lannka merged commit 3ddf13b into ampproject:master Jan 24, 2018
3P Ads & Analytics Support automation moved this from TODO to Done Jan 24, 2018
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018
* add support for byside analytics

* update byside analytics integration tests

* update analytics vendor example for byside
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
* add support for byside analytics

* update byside analytics integration tests

* update analytics vendor example for byside
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants