Write AMP_CONFIG to 3p frame to enable local development #12703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
changed the title
This was referenced Jan 8, 2018
bradfrizzell
approved these changes
Jan 8, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes
gulp | gulp watch | gulp build | gulp dist --fortestingto writeAMP_CONFIGto the 3p frame target file in addition to the AMP runtime file. This enables testing with non-localhost servers.In addition, now that we're writing
AMP_CONFIGby default to the runtime file and the 3p frame file, we can simplify the heroku setup scripts to no longer have to invokegulp prepend-global.For context, see #12054 (comment)
Follow up to #12673
Unblocks #12666
Fixes #12054