Add TGT macro for targeting data in json #12707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkeller
approved these changes
Jan 8, 2018
keithwrightbos
requested changes
Jan 8, 2018
| @@ -741,6 +741,10 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A { | |||
| return { | |||
| PAGEVIEWID: () => Services.documentInfoForDoc(this.element).pageViewId, | |||
| HREF: () => this.win.location.href, | |||
| TGT: () => { | |||
| const json = tryParseJson(this.element.getAttribute('data-json')); | |||
There was a problem hiding this comment.
TGT: () => (tryParseJson(this.element.getAttribute('data-json')) || {})['targeting'] || '',
| @@ -294,6 +297,7 @@ describes.realWin('DoubleClick Fast Fetch RTC', {amp: true}, env => { | |||
| 'data-multi-size-validation': macros['data-multi-size-validation'], | |||
| 'data-override-width': macros['data-OVERRIDE-width'], | |||
| 'data-override-height': macros['data-override-HEIGHT'], | |||
| 'data-json': JSON.stringify(json), | |||
There was a problem hiding this comment.
does your test coverage handle the case where data-json exists but without targeting key?
keithwrightbos
approved these changes
Jan 9, 2018
|
Hey, @bradfrizzell |
|
@monish-chhadwa Good catch, follow up PR to fix here: #12841 |
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* Add TGT macro for targeting data in json * Respond to feedback * golf * Fix * fix check-types * fix
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Add TGT macro for targeting data in json * Respond to feedback * golf * Fix * fix check-types * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12374