Use try catch to protect querySelector #12734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
commented
Jan 9, 2018
| try { | ||
| found = scopedQuerySelector(context, selector); | ||
| } catch (e) { | ||
| user().error(TAG, 'Invalid query selector :', selector, e); |
There was a problem hiding this comment.
We also throw user error when can't find target element. I figure invalid selector is somehow different from that error.
Let me know if two errors "invalid selector" + "element not found" are not wanted..
zhouyx
force-pushed
the
syntax-error-throw
branch
from
8b51e4c
to
7083d9b
Compare
lannka
reviewed
Jan 10, 2018
| if (found && this.contains(found)) { | ||
| result = found; | ||
| } | ||
| return user().assertElement( |
There was a problem hiding this comment.
we can move this to be after the catch block to avoid doubling the error messages.
lannka
approved these changes
Jan 10, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* use try catch to protect querySelector * only send one error * reorder
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* use try catch to protect querySelector * only send one error * reorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12563