Check sandboxed analytics component parentElement exist #12746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Jan 9, 2018
| @@ -305,6 +305,10 @@ export class AmpAnalytics extends AMP.BaseElement { | |||
| // replace selector and selectionMethod | |||
| if (this.isSandbox_) { | |||
| // Only support selection of parent element for analytics in scope | |||
| if (!this.element.parentElement) { | |||
| // In case parent element has been removed from DOM, do nothing | |||
There was a problem hiding this comment.
We do call removeElement. For example, user remove sticky ad that has analytics component as a child.
lannka
approved these changes
Jan 9, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12062