amp-lightbox: Better resource scheduling for scrollable lightbox #12751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erwinmombay Can we wait to get this into Canary if not cut yet? |
| // Check whether child element is visible in the lightbox given | ||
| const descendants = this.getComponentDescendants_(); | ||
| for (let i = 0; i < descendants.length; i++) { | ||
| const child = descendants[i]; |
| const child = descendants[i]; | ||
| let offsetTop = 0; | ||
| for (let n = child; n && this.element.contains(n); | ||
| n = n./*OK*/offsetParent) { |
There was a problem hiding this comment.
Nit: Formatting.
for (let n = child;
n && this.element.contains(n);
n = n./*OK*/offsetParent) {
offsetTop += n./*OK*/offsetTop;
}|
|
||
| this.element.addEventListener(AmpEvents.DOM_UPDATE, () => { | ||
| this.takeOwnershipOfDescendants_(); | ||
| this.updateChildrenInViewport_(this.pos_, this.pos_); |
There was a problem hiding this comment.
This means we won't call updateInViewport for new children. WAI?
There was a problem hiding this comment.
We would, on debounced scroll we also calculate visible children and call scheduleLayout and updateInViewport on them.
jridgewell
approved these changes
Jan 10, 2018
dreamofabear
approved these changes
Jan 10, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12685
Temporary solution for high priority #12685. Layers will fix all the crazyness here.
Previous solution had the following bugs:
offsetTopcalculation were wrong and only worked when there was no otheroffsetParent(Unfortunately all the problems above also exist for scrollable version of
amp-carousel. Given layers is the right solution and there hasn't been a high priority need, I don't recommend porting these toamp-carousel)